Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/column number #918

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Fix/column number #918

merged 1 commit into from
Dec 17, 2022

Conversation

Utkarsh-khambra
Copy link
Collaborator

Description

Describe your changes in detail

In default config
When scrollbar is hidden, the terminal viewport is actually 81 cols because the scrollbar space is also used for columns too. So here I subtract scrollBar width from total width. This keeps the number columns same for both hidden scrollbar and visible scrollbar.

Motivation and Context

Why is this change required? What problem does it solve?

Because if terminal width is specified to be 80 cols then it should be 80 cols for both scrollbar hidden and visible.

How Has This Been Tested?

  • Please describe how you tested your changes.
    Run printf '\e[18t' to check number of columns.
  • see how your change affects other areas of the code, etc.
    It doesn't affect other parts of code

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • I have read the CONTRIBUTING document in my spoken language, and understand the terms
  • I have updated (or added) the documentation accordingly.
  • I have added tests to cover my changes.
  • I have gone through all the steps, and have thoroughly read the instructions

@github-actions github-actions bot added the VT: Backend Virtual Terminal Backend (libterminal API) label Dec 17, 2022
@Utkarsh-khambra Utkarsh-khambra force-pushed the fix/column_number branch 3 times, most recently from e6a48a8 to 8e97428 Compare December 17, 2022 18:55
@christianparpart christianparpart merged commit a7bb938 into master Dec 17, 2022
@christianparpart christianparpart deleted the fix/column_number branch December 17, 2022 20:01
christianparpart added a commit that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants